Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated df.append method with pd.concat #3753

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

skhan877
Copy link
Contributor

Description

append method deprecated. pandas suggest replacing with concat.
Fixes issue #3707

How has this been tested?

load any exchange in the following menu
/stocks/th/exchange

future warning no longer shows after method replaced.

@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 10, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 12, 2022
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 12, 2022
Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@reviewpad reviewpad bot added feat XS Extra small feature and removed feat XS Extra small feature labels Dec 12, 2022
@montezdesousa montezdesousa merged commit 4bbfafa into OpenBB-finance:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants