Add tweet news in terminal toolbar #3757

DidierRLopes · 2022-12-11T14:39:58Z

Let me know if there's anything else you want me to do!

jmaslek · 2022-12-13T00:28:49Z

Same thing is happening to me that was happening on the mstarpy branch.

Package operations: 2 installs, 80 updates, 2 removals

  • Removing setuptools (65.4.1)
  • Removing wheel (0.38.4)

@Chavithra @piiq Do we need to add setuptools to poetry?

Although running poetry install breaks stuff

• Updating regex (2022.3.2 -> 2022.10.31): Installing...
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating jupyterlab-widgets (3.0.3 -> 3.0.4)
  • Updating lazy-object-proxy (1.7.1 -> 1.8.0)
  • Updating notebook (6.5.1 -> 6.5.2): Installing...
  • Updating plotly (5.10.0 -> 5.11.0): Installing...
  • Updating pycares (4.2.2 -> 4.3.0)
  • Updating pyobjc-core (8.5.1 -> 9.0): Installing...
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources
  • Updating jupyterlab-server (2.16.1 -> 2.16.5)
  • Updating jupyterlab-widgets (3.0.3 -> 3.0.4)
  • Updating lazy-object-proxy (1.7.1 -> 1.8.0)
  • Updating notebook (6.5.1 -> 6.5.2): Installing...
  • Updating plotly (5.10.0 -> 5.11.0): Installing...
  • Updating pycares (4.2.2 -> 4.3.0)
  • Updating pyobjc-core (8.5.1 -> 9.0): Installing...
  • Updating regex (2022.3.2 -> 2022.10.31)
  • Updating widgetsnbextension (4.0.3 -> 4.0.4): Failed

  EnvCommandError

  Command ['/Users/james/miniconda3/envs/obb/bin/pip', 'install', '--no-deps', '-U', '/Users/james/Library/Caches/pypoetry/artifacts/62/09/cd/274e73ad1110ae9cc381f10e793ccd028c87c6f098e13c443ebcdc25c2/widgetsnbextension-4.0.4-py3-none-any.whl'] errored with the following return code 2, and output: 
  ERROR: Exception:
  Traceback (most recent call last):
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
      status = run_func(*args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
      return func(self, options, args)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 326, in run
      session = self.get_default_session(options)
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
      self._session = self.enter_context(self._build_session(options))
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
      session = PipSession(
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 343, in __init__
      self.headers["User-Agent"] = user_agent()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/network/session.py", line 175, in user_agent
      setuptools_dist = get_default_environment().get_distribution("setuptools")
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 75, in get_default_environment
      return select_backend().Environment.default()
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/__init__.py", line 63, in select_backend
      from . import pkg_resources
    File "/Users/james/miniconda3/envs/obb/lib/python3.9/site-packages/pip/_internal/metadata/pkg_resources.py", line 8, in <module>
      from pip._vendor import pkg_resources

piiq

Please:

Make sure that there is exception handling in place for situations when data is queried for non-popular instruments
Make sure that timeouts for people who don't have twitter keys or are in networks where twitter is blocked are 1 second and less
Add unit tests for every function that you have added

jmaslek · 2023-02-02T16:46:24Z

https://techcrunch.com/2023/02/01/twitter-to-end-free-access-to-its-api/?guccounter=1&guce_referrer=aHR0cHM6Ly93d3cuYmluZy5jb20v&guce_referrer_sig=AQAAAIfbpM1o0f_hqTCF2yXUIeoiC3ccQaWgV2iFFqWJOffvqMdRQbVo8852Gxr578cE9oC3pd48mfMNkuFRFx2IzS0M4vF3S7HMCp1OC0bG7fnudoOMop-nyUuy2MZmAWb8NIGn6DsRGqViA6dLfEJr1Dqv0K9HeUVkH7tiekz67qCQ

Chavithra

Looks ok to me.

There is a API_TWITTER_BEARER_TOKEN loading issue : this feature requires the credentials to be loaded sooner.

But I think we should try to resolve that on the credentials refactoring that is planned.

For now it works if we put the credentials on config_terminal.py.

This reverts commit 4493f1a.

Dependencies were updated.

Add tweet news in terminal toolbar

b589beb

reviewpad bot added the feat S Small T-Shirt size Feature label Dec 11, 2022

allow to store tweet news settings

fc0152f

reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Dec 11, 2022

Merge branch 'main' into newsbanner

29e599c

reviewpad bot added feat M Medium T-Shirt size feature and removed feat M Medium T-Shirt size feature labels Dec 11, 2022

DidierRLopes marked this pull request as ready for review December 11, 2022 23:48

reviewpad bot added feat M Medium T-Shirt size feature and removed feat M Medium T-Shirt size feature labels Dec 11, 2022

DidierRLopes requested review from jmaslek and Chavithra December 11, 2022 23:48

reviewpad bot added feat M Medium T-Shirt size feature and removed feat M Medium T-Shirt size feature labels Dec 11, 2022

update dependencies

34c6807

reviewpad bot added feat M Medium T-Shirt size feature and removed feat M Medium T-Shirt size feature labels Dec 12, 2022

DidierRLopes added 4 commits December 13, 2022 09:02

Add tweet news in terminal toolbar

a44efc0

merge

f319098

lint

8708765

dependencies

e77bbd2

piiq previously requested changes Dec 13, 2022

View reviewed changes

Merge branch 'develop' into newsbanner

c0da568

Chavithra added 9 commits February 22, 2023 00:00

News Toolbar : Fix bugs

685b9bf

Tests : News Toolbar

f49e6f3

Merge remote-tracking branch 'origin/develop' into newsbanner

fad9cde

Update dependencies

5334d52

Tests : change variable name

202484f

Remove unused keys

0480c2e

Remove unecessary global variable

a24744b

Fix linting

f4af57f

Lighter API call

e971e06

Chavithra approved these changes Feb 22, 2023

View reviewed changes

Chavithra added 9 commits February 22, 2023 02:18

Ruff

f8cab4f

Linting + Remove keys

500999e

Linting

61da238

Dotenv loading issue.

4493f1a

Merge branch 'develop' into newsbanner

f5d6d0f

Ruff

4f2b6ee

Revert "Dotenv loading issue."

f51beb0

This reverts commit 4493f1a.

Merge branch 'develop' into newsbanner

206f753

Tests : fix

c6c9830

reviewpad bot added feat L Large T-Shirt size Feature and removed feat M Medium T-Shirt size feature labels Feb 22, 2023

Chavithra added 2 commits February 23, 2023 09:58

Tests : fix test_settings_controller.py

9ebb009

Twitter Toolbar : avoid checking API when not enabled

797a3f0

Tests : news toolbar

4259f5c

Chavithra merged commit f1a824a into develop Feb 23, 2023

Chavithra deleted the newsbanner branch February 23, 2023 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tweet news in terminal toolbar #3757

Add tweet news in terminal toolbar #3757

DidierRLopes commented Dec 11, 2022 •

edited

Loading

jmaslek commented Dec 13, 2022 •

edited

Loading

piiq left a comment

jmaslek commented Feb 2, 2023

Chavithra left a comment •

edited

Loading

Add tweet news in terminal toolbar #3757

Add tweet news in terminal toolbar #3757

Conversation

DidierRLopes commented Dec 11, 2022 • edited Loading

jmaslek commented Dec 13, 2022 • edited Loading

piiq left a comment

Choose a reason for hiding this comment

jmaslek commented Feb 2, 2023

Chavithra left a comment • edited Loading

Choose a reason for hiding this comment

DidierRLopes commented Dec 11, 2022 •

edited

Loading

jmaslek commented Dec 13, 2022 •

edited

Loading

Chavithra left a comment •

edited

Loading