Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps update (#3800) #3801

Merged
merged 36 commits into from
Dec 20, 2022
Merged

deps update (#3800) #3801

merged 36 commits into from
Dec 20, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Dec 19, 2022

Need to bump requirements for yf.

Building the installers now to confirm

Following commands were run:

poetry add yfinance@latest
poetry update

@jmaslek jmaslek added bug Fix bug build Build-related work labels Dec 19, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 19, 2022
@jmaslek
Copy link
Collaborator Author

jmaslek commented Dec 19, 2022

statsmodels needs to be at 0.13.2 because of scipy

@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat XS Extra small feature labels Dec 19, 2022
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat M Medium T-Shirt size feature labels Dec 19, 2022
pyproject.toml Outdated
@@ -44,7 +44,7 @@ pycoingecko = "^2.2.0"
detecta = "^0.0.5"
tradingview-ta = "^3.2.3"
finvizfinance = "^0.14.0"
statsmodels = "^0.13"
statsmodels = "0.13.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaslek can we have statsmodels = ">=0.13.2" so we don't pin an exact version or this will cause scipy to break?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causes the dep tree to break.

@hjoaquim
Copy link
Contributor

Works fine for git clone - ubuntu!
Will give it a try on Win10 installer as soon as the build finish.

@hjoaquim
Copy link
Contributor

hjoaquim commented Dec 19, 2022

Fix #3796
Fix #3789
Fix #3803

@jmaslek
Copy link
Collaborator Author

jmaslek commented Dec 19, 2022

okay i got all the tests to pass (hence the 1Mil net adds).

however the installers are not building correctly. and the anaconda builds are struggling.

@piiq piiq added the do not merge Label to prevent pull request merge label Dec 20, 2022
@piiq piiq removed the do not merge Label to prevent pull request merge label Dec 20, 2022
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built an M1 installer of this branch and it works.
The windows installer has just finished building and @andrewkenreich will have a look if it passes the smoke test on a windows machine. If so - we're good to merge this one

- ARKW: No data found for this date range, symbol may be delisted
ETF ticker provided does not exist!

No ticker loaded. First use `load {ticker}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh! is this the test output we actually need?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working for me on windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug build Build-related work feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants