-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps update (#3800) #3801
deps update (#3800) #3801
Conversation
statsmodels needs to be at 0.13.2 because of scipy |
pyproject.toml
Outdated
@@ -44,7 +44,7 @@ pycoingecko = "^2.2.0" | |||
detecta = "^0.0.5" | |||
tradingview-ta = "^3.2.3" | |||
finvizfinance = "^0.14.0" | |||
statsmodels = "^0.13" | |||
statsmodels = "0.13.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmaslek can we have statsmodels = ">=0.13.2"
so we don't pin an exact version or this will cause scipy to break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Causes the dep tree to break.
Works fine for git clone - ubuntu! |
okay i got all the tests to pass (hence the 1Mil net adds). however the installers are not building correctly. and the anaconda builds are struggling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've built an M1 installer of this branch and it works.
The windows installer has just finished building and @andrewkenreich will have a look if it passes the smoke test on a windows machine. If so - we're good to merge this one
- ARKW: No data found for this date range, symbol may be delisted | ||
ETF ticker provided does not exist! | ||
|
||
No ticker loaded. First use `load {ticker}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh! is this the test output we actually need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working for me on windows
Need to bump requirements for yf.
Building the installers now to confirm
Following commands were run: