Display daily returns as bar chart with color=red for negative return… #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and color=green for positive return
|
This definitely looks a lot nicer! One question, instead of using red/green, can we use the custom theme files? They are: Then it is theme.up_color or theme.down_color instead of red/green |
…gative returns and color=theme.up_color for positive return
|
Of course, fixed it. |
jmaslek
approved these changes
Jan 3, 2023
|
Nice! The linter is now yelling. Running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and color=green for positive return
Description
The displayed daily return as given by the
dret_chartcommand is implemented as a connected line chart. I think a bar chart is more visually appealing. I've gone further and added red/green color for returns below/above zero. See example:Before:
After:
