Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_loaded made more readable #3859

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

MertNuhuz
Copy link
Contributor

I made these changes is to make the code more readable and understandable.

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

I made these changes is to make the code more readable and understandable.
@reviewpad reviewpad bot added the feat XS Extra small feature label Jan 3, 2023
@MertNuhuz
Copy link
Contributor Author

sorry, i forgot to add "refactor" label in my pr

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

│ Loaded files and data columns:                                                                                                                              │
│         strikes : duration, iprod                                                                                                                           │
│         aapl1   : date, open, high, low, close, adj_close, volume     

@jmaslek jmaslek merged commit 450e78d into OpenBB-finance:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants