Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing timezone not updating within same terminal session #3871

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

AlisonB319
Copy link
Contributor

@AlisonB319 AlisonB319 commented Jan 5, 2023

overrideing the get_user_timezone() so that the updated timezone variable is used. Previsously openbb needed to be restarted to reflect the change

#3863

timezoneBugFix.mp4

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

overrideing the get_user_timezone() so that the updated timezone variable is used
@reviewpad reviewpad bot added the feat XS Extra small feature label Jan 5, 2023
@montezdesousa montezdesousa self-requested a review January 5, 2023 10:03
Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants