Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitflow - Autodoc #3922

Merged
merged 36 commits into from
Jan 11, 2023
Merged
Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
872662d
testing gitflow
luqmanbello Jan 9, 2023
e947570
Name changes
luqmanbello Jan 9, 2023
59f69c0
Testing python changes
luqmanbello Jan 9, 2023
4f8bde5
Added Checkout to Base test
luqmanbello Jan 9, 2023
913d420
More minor fixes for merge
luqmanbello Jan 9, 2023
fcda8da
Minor fix
luqmanbello Jan 9, 2023
dc3e15a
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 9, 2023
31b9184
Added nightly build
luqmanbello Jan 9, 2023
8d4e3d6
Testing Merge
luqmanbello Jan 9, 2023
f899d6d
Merge error fix
luqmanbello Jan 9, 2023
925477a
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 9, 2023
9bce0f2
Merge fix
luqmanbello Jan 9, 2023
9210ec9
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 9, 2023
3402c03
merge fix
luqmanbello Jan 10, 2023
a0a016e
Merge branch 'feature/gitflow' of https://github.com/OpenBB-finance/O…
luqmanbello Jan 10, 2023
3a92505
Merge fix
luqmanbello Jan 10, 2023
8be596c
Merge fix
luqmanbello Jan 10, 2023
d896d22
Merge fix
luqmanbello Jan 10, 2023
801d3bf
merge fix
luqmanbello Jan 10, 2023
74cd295
[Gitflow] - Minor fix
luqmanbello Jan 10, 2023
645f15d
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 10, 2023
3d1eb29
Feature/gitflow (#3914) (#3915)
luqmanbello Jan 10, 2023
a033914
Nightly build feature
luqmanbello Jan 10, 2023
1f05d90
Added branch name docs
luqmanbello Jan 10, 2023
8ace8e0
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 10, 2023
a642334
Auto doc adjustment
luqmanbello Jan 10, 2023
16b5bb6
Fix markdown
luqmanbello Jan 10, 2023
206e568
Markdown fix
luqmanbello Jan 10, 2023
f6836c7
markdown fix
luqmanbello Jan 10, 2023
ea5f013
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 10, 2023
7626709
code linting error fix
luqmanbello Jan 10, 2023
6f42b3a
fix linting test issue
luqmanbello Jan 11, 2023
907a72f
Merge branch 'develop' into feature/gitflow
luqmanbello Jan 11, 2023
24ad589
Fixed linting check
luqmanbello Jan 11, 2023
d53aafb
linting fix
luqmanbello Jan 11, 2023
32aee17
ruff version fix
luqmanbello Jan 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
name: Deploy to GitHub Pages

on:
push:
pull_request:
branches:
- main
types: [closed]


jobs:
generate:
name: Generate and Deploy documentation
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
- name: Git checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
MPLBACKEND: Agg
run: |
source $VENV
pytest tests/ --optimization
pytest tests/ --optimization --autodoc

- name: Start Terminal and exit
run: |
Expand Down
8 changes: 5 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -1530,13 +1530,15 @@ Network model.
to go back to step 3 to add these.

### Branch Naming Conventions

The accepted branch naming conventions are:

- `feature/feature-name`
- `hotfix/hotfix-name`
- `release/2.1.0` or `release/2.1.0rc0`.
- `feature/feature-name`
- `hotfix/hotfix-name`
- `release/2.1.0` or `release/2.1.0rc0`.

All `feature/feature-name` related branches can only have PRs pointing to `develop` branch. `hotfix/hotfix-name` and `release/2.1.0` or `release/2.1.0rc0` branches can only have PRs pointing to `main` branch.

## Add a Test

Unit tests minimize errors in code and quickly find errors when they do arise. Integration tests are standard usage examples, which are also used to identify errors.
Expand Down
4 changes: 0 additions & 4 deletions gitflow.py

This file was deleted.

2 changes: 1 addition & 1 deletion tests/test_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ def no_dfs(args: list, kwargs: dict) -> bool:
for item in kwargs.values():
if isinstance(item, pd.DataFrame):
return False
return True
return True