Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor stocks/fa by incorporating stocks/dd and making the menu less reliant on Yahoo Finance #4055

Merged
merged 57 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
630f824
I missed some sheet_name ones :)
Jan 26, 2023
40cb383
Move quote to main menu and combine yahoo finance commands
Jan 26, 2023
a42d7c0
Update stocks for quote
Jan 26, 2023
464f0c2
First update to move yfinance away from main functionality
Jan 26, 2023
cbd0852
Small updates
Jan 26, 2023
cbdde30
Update tests to reflect changes
Jan 26, 2023
2d869c7
Fix some little things
Jan 26, 2023
d682edd
Update docs a little too
Jan 26, 2023
1665c13
Remove the Due Diligence menu
Jan 27, 2023
00e194b
Update tests for new change
Jan 27, 2023
22de01e
Update fa and stocks with new text and move some stuff around
Jan 27, 2023
801ffcc
Bye bye dd
Jan 27, 2023
0897d31
Pls work
JerBouma Jan 30, 2023
7e419ef
work..
JerBouma Jan 30, 2023
f8de870
work..
JerBouma Jan 30, 2023
3a3ed2a
work..
JerBouma Jan 30, 2023
1d45863
Work..|
JerBouma Jan 30, 2023
8577100
Add tests back in
JerBouma Jan 30, 2023
1e87327
Remove tests
JerBouma Jan 30, 2023
e947032
Fix fix fix
JerBouma Jan 30, 2023
9c8a4f4
Merge branch 'develop' into feature/yfinance-refractor-stocks
jmaslek Jan 30, 2023
9616bbc
Remove tests to fix conflicts
JerBouma Feb 1, 2023
cef2287
Improve the `stocks/search` command (#4084)
JerBouma Jan 31, 2023
121f149
Update commands with --sheet-name that didn't work (#4088)
JerBouma Jan 31, 2023
de1e971
Adds auto completion to `news` (#4089)
hjoaquim Jan 31, 2023
ea9221f
Hotfix/Windows-CLI (#4087)
tehcoderer Jan 31, 2023
7358b4c
Adds end date to `forex/load` (#4077)
hjoaquim Jan 31, 2023
049a6c5
Update tests to reflect changes
Jan 26, 2023
b73b056
work..
JerBouma Jan 30, 2023
38894c4
Remove tests
JerBouma Jan 30, 2023
571182f
Fix fix fix
JerBouma Jan 30, 2023
5d997bf
Remove tests
JerBouma Feb 1, 2023
ee3fee5
Update the whole test folder
JerBouma Feb 1, 2023
2e79eaa
Merge branch 'develop' into feature/yfinance-refractor-stocks
JerBouma Feb 1, 2023
1afd42c
Small updates
JerBouma Feb 1, 2023
fd01f9c
Revert change
JerBouma Feb 1, 2023
e6a36a8
Update eodhd to reflect it requires a paid plan and update tests
JerBouma Feb 1, 2023
e841acc
Merge branch 'develop' into feature/yfinance-refractor-stocks
JerBouma Feb 1, 2023
53cf0b3
Fix all the tests
JerBouma Feb 1, 2023
f2e197f
Update tests
JerBouma Feb 1, 2023
0cbe242
Update integration tests
JerBouma Feb 1, 2023
497de48
Removing tests so no whining happens
JerBouma Feb 3, 2023
c89570d
Merge branch
JerBouma Feb 3, 2023
7fbbc9f
ADD ALL THE TESTS
JerBouma Feb 3, 2023
95db018
Fix linting
JerBouma Feb 3, 2023
585422c
gitignore. thanks jer
jmaslek Feb 3, 2023
1db9146
Merge branch 'develop' into feature/yfinance-refractor-stocks
jmaslek Feb 3, 2023
dbd2d16
Add back dd and redirect to fa
JerBouma Feb 3, 2023
07c734e
Merge branch 'develop' into feature/yfinance-refractor-stocks
jmaslek Feb 3, 2023
a2f8f33
Update to just display a message
JerBouma Feb 3, 2023
1440c02
Update OpenBB SDK commands
JerBouma Feb 6, 2023
7b9c5cc
Fixing issues with exporting
JerBouma Feb 6, 2023
d8765cb
Merge
JerBouma Feb 6, 2023
79cd29d
Merge branch 'develop' into feature/yfinance-refractor-stocks
JerBouma Feb 6, 2023
923a4de
Fix ruff messing up
JerBouma Feb 6, 2023
73b4492
Fix tests
JerBouma Feb 6, 2023
d4b6b2b
Fix the tests by disabling isort to run on tests folder
jmaslek Feb 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ website/functions
*_sdk_audit.csv
website/terminaltest
!build/docker/compose.env
.dccache

# pyinstaller artifacts
*.pyo
Expand Down
52 changes: 20 additions & 32 deletions openbb_terminal/miscellaneous/data_sources_default.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"stocks": {
"filings": ["FinancialModelingPrep"],
"search": ["FinanceDatabase"],
"quote": ["YahooFinance"],
"quote": ["FinancialModelingPrep", "YahooFinance"],
"tob": ["CBOE"],
"candle": [],
"codes": ["Polygon"],
Expand Down Expand Up @@ -94,16 +93,15 @@
"dps": {
"load": ["YahooFinance", "IEXCloud", "AlphaVantage", "Polygon", "EODHD"],
"shorted": ["YahooFinance"],
"ctb": ["InteractiveBrokers"],
"ctb": ["InteractiveBrokers", "Stocksera"],
"hsi": ["Shortinterest"],
"prom": ["FINRA"],
"pos": ["Stockgrid"],
"sidtc": ["Stockgrid"],
"dpotc": ["FINRA"],
"ftd": ["SEC"],
"spos": ["Stockgrid"],
"psi": ["Stockgrid", "Quandl"],
"ctb": ["ibkr", "stocksera"]
"psi": ["Stockgrid", "Quandl"]
},
"scr": {
"view": [],
Expand Down Expand Up @@ -210,64 +208,54 @@
"fa": {
"load": ["YahooFinance", "IEXCloud", "AlphaVantage", "Polygon", "EODHD"],
"income": [
"YahooFinance",
"FinancialModelingPrep",
"Polygon",
"AlphaVantage",
"FinancialModelingPrep",
"EODHD"
"EODHD",
"YahooFinance"
],
"balance": [
"YahooFinance",
"FinancialModelingPrep",
"Polygon",
"AlphaVantage",
"FinancialModelingPrep",
"EODHD"
"EODHD",
"YahooFinance"
],
"cash": [
"YahooFinance",
"FinancialModelingPrep",
"Polygon",
"AlphaVantage",
"FinancialModelingPrep",
"EODHD"
"EODHD",
"YahooFinance"
],
"data": ["Finviz"],
"overview": ["Finviz", "FinancialModelingPrep", "AlphaVantage", "YahooFinance"],
"mgmt": ["BusinessInsider"],
"analysis": ["Elect"],
"score": ["FinancialModelingPrep"],
"profile": ["FinancialModelingPrep"],
"quote": ["FinancialModelingPrep"],
"enterprise": ["FinancialModelingPrep"],
"metrics": ["FinancialModelingPrep"],
"enterprise": ["FinancialModelingPrep", "YahooFinance"],
"metrics": ["FinancialModelingPrep", "AlphaVantage"],
"ratios": ["FinancialModelingPrep"],
"growth": ["FinancialModelingPrep"],
"revfc": ["SeekingAlpha"],
"revfc": ["SeekingAlpha", "YahooFinance"],
"epsfc": ["SeekingAlpha"],
"warnings": ["MarketWatch"],
"dcf": ["StockAnalysis"],
"dcfc": ["FinancialModelingPrep"],
"info": ["YahooFinance"],
"mktcap": ["YahooFinance"],
"shrs": ["YahooFinance"],
"sust": ["YahooFinance"],
"cal": ["YahooFinance"],
"divs": ["YahooFinance"],
"splits": ["YahooFinance"],
"web": ["YahooFinance"],
"hq": ["YahooFinance"],
"overview": ["AlphaVantage"],
"key": ["AlphaVantage"],
"earnings": ["YahooFinance", "AlphaVantage"],
"earnings": ["AlphaVantage", "YahooFinance"],
"fraud": ["AlphaVantage"],
"dupont": ["AlphaVantage"]
},
"dd": {
"load": ["YahooFinance", "IEXCloud", "AlphaVantage", "Polygon", "EODHD"],
"analyst": ["Finviz"],
"rating": ["FinancialModelingPrep"],
"dupont": ["AlphaVantage"],
"rating": ["Finviz", "FinancialModelingPrep"],
"rot": ["Finnhub"],
"pt": ["BusinessInsider"],
"est": ["BusinessInsider"],
"sec": ["MarketWatch"],
"sec": ["MarketWatch", "FinancialModelingPrep"],
"supplier": ["CSIMarket"],
"customer": ["CSIMarket"],
"arktrades": ["Cathiesark"]
Expand Down
67 changes: 29 additions & 38 deletions openbb_terminal/miscellaneous/i18n/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ en:
stocks/gov: government menu, house trading, contracts, corporate lobbying
stocks/ba: behavioural analysis, from reddit, stocktwits, twitter, google
stocks/ca: comparison analysis, get similar, historical, correlation, financials
stocks/fa: fundamental analysis, income, balance, cash, earnings
stocks/fa: fundamental analysis, income, balance, cash, ratios, earnings, expectations
stocks/res: research web page, macroaxis, yahoo finance, fool
stocks/dd: in-depth due-diligence, news, analyst, shorts, insider, sec
stocks/bt: strategy backtester, simple ema, ema cross, rsi strategies
stocks/ta: technical analysis, ema, macd, rsi, adx, bbands, obv
stocks/qa: quantitative analysis, decompose, cusum, residuals analysis
Expand Down Expand Up @@ -328,37 +327,40 @@ en:
stocks/ba/jctr: Jim Cramer's recommendations by ticker
stocks/fa/load: load a specific stock ticker for analysis
stocks/fa/_ticker: Ticker
stocks/fa/data: fundamental and technical data of company
stocks/fa/mgmt: management team of the company
stocks/fa/analysis: analyse SEC filings with the help of machine learning
stocks/fa/score: investing score from Warren Buffett and co
stocks/fa/warnings: company warnings according to Sean Seah book
stocks/fa/dcf: advanced Excel customizable discounted cash flow
stocks/fa/info: information scope of the company
stocks/fa/mktcap: estimated market cap
stocks/fa/shrs: shareholders (insiders, institutions and mutual funds)
stocks/fa/sust: sustainability values (environment, social and governance)
stocks/fa/cal: calendar earnings and estimates of the company
stocks/fa/_company_overview: Company Overview
stocks/fa/enterprise: company enterprise value
stocks/fa/overview: financial overview of the company
stocks/fa/divs: show historical dividends for company
stocks/fa/splits: stock split and reverse split events since IPO
stocks/fa/web: open web browser of the company
stocks/fa/hq: open HQ location of the company
stocks/fa/rating: analyst prices and ratings over time of the company
stocks/fa/rot: number of analyst ratings over time on a monthly basis
stocks/fa/score: value investing scores for any time period
stocks/fa/warnings: company warnings according to Sean Seah book
stocks/fa/sust: sustainability values (environment, social and governance)
stocks/fa/arktrades: get ARK trades for ticker
stocks/fa/_management_shareholders: Management and Ownership
stocks/fa/mgmt: management team of the company
stocks/fa/shrs: shareholders (insiders, institutions and mutual funds)
stocks/fa/supplier: list of suppliers for the company
stocks/fa/customer: list of customers of the company
stocks/fa/_financial_statements: Financial Statements
stocks/fa/income: income statements of the company
stocks/fa/balance: balance sheet of the company
stocks/fa/overview: overview of the company
stocks/fa/key: company key metrics
stocks/fa/cash: cash flow of the company
stocks/fa/earnings: earnings dates and reported EPS
stocks/fa/fraud: key fraud ratios
stocks/fa/dupont: detailed breakdown for return on equity
stocks/fa/profile: company profile
stocks/fa/quote: detailed stock quote information
stocks/fa/enterprise: company enterprise value
stocks/fa/metrics: key metrics over time
stocks/fa/ratios: in-depth ratios over time
stocks/fa/balance: balance sheet statements of the company
stocks/fa/cash: cash flow statements of the company
stocks/fa/growth: growth of financial statement items and ratios
stocks/fa/metrics: key financial metrics over time
stocks/fa/ratios: extensive set of ratios over time
stocks/fa/dupont: detailed breakdown for Return on Equity (RoE)
stocks/fa/fraud: key fraud ratios including M-score, Z-score and McKee
stocks/fa/sec: obtain recent SEC filings of the company
stocks/fa/analysis: analyse SEC filings with the help of machine learning
stocks/fa/_future_estimations: Future Expectations
stocks/fa/earnings: earnings dates and reported EPS
stocks/fa/epsfc: Earning Estimate by Analysts - EPS
stocks/fa/revfc: Earning Estimate by Analysts - Revenue
stocks/fa/est: quarter and year analysts earnings estimates
stocks/fa/pt: price targets over time
stocks/fa/dcf: advanced Excel customizable discounted cash flow
stocks/fa/dcfc: determine the (historical) discounted cash flow
stocks/res/_ticker: Ticker
stocks/res/macroaxis: www.macroaxis.com
Expand All @@ -380,17 +382,6 @@ en:
stocks/res/macrotrends: www.macrotrends.net
stocks/res/newsfilter: www.newsfilter.io
stocks/res/stockanalysis: www.stockanalysis.com
stocks/dd/load: load a specific stock ticker for analysis
stocks/dd/_ticker: Ticker
stocks/dd/analyst: analyst prices and ratings of the company
stocks/dd/rating: rating over time (daily)
stocks/dd/rot: number of analysts ratings over time (monthly)
stocks/dd/pt: price targets over time
stocks/dd/est: quarter and year analysts earnings estimates
stocks/dd/sec: SEC filings
stocks/dd/supplier: list of suppliers
stocks/dd/customer: list of customers
stocks/dd/arktrades: get ARK trades for ticker
stocks/bt/_ticker: Ticker
stocks/bt/whatif: what if you had bought X shares on day Y
stocks/bt/ema: buy when price exceeds EMA(l)
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,35 +13,44 @@ cash -l 2 --source YahooFinance
cash -l 2 --source Polygon
cash -l 2 --source AlphaVantage
cash -l 2 --source FinancialModelingPrep
data
mgmt
analysis
score
profile
quote
enterprise
metrics
ratios
growth
warnings
warnings -d
dcfc
info
mktcap
enterprise
shrs
shrs major
shrs mutualfund
sust
cal
divs
divs -p
splits
overview
key
earnings --source YahooFinance
earnings --source AlphaVantage
fraud
dupont
epsfc
revfc
analysis
rating
rot
rot -l 3 --raw
pt
pt -l 3 --raw
est
est -e annualrevenue
est -e annualearnings
est -e quarterearnings
sec
supplier
customer
load ${ticker=tsla}
arktrades
exit
4 changes: 2 additions & 2 deletions openbb_terminal/stocks/dark_pool_shorts/dps_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,15 @@ def call_ctb(self, other_args: List[str]):
parser, other_args, EXPORT_ONLY_RAW_DATA_ALLOWED
)
if ns_parser:
if ns_parser.source == "ibkr":
if ns_parser.source == "InteractiveBrokers":
ibkr_view.display_cost_to_borrow(
limit=ns_parser.number,
export=ns_parser.export,
sheet_name=" ".join(ns_parser.sheet_name)
if ns_parser.sheet_name
else None,
)
else:
elif ns_parser.source == "Stocksera":
stocksera_view.cost_to_borrow(
self.ticker, limit=ns_parser.number, raw=ns_parser.raw
)
Expand Down
Loading