-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixed income menu #4071
Add fixed income menu #4071
Conversation
Also moved the yrcv command from economy to fixed income
I'm going ham on this PR right now. Will make a bunch of adjustments. |
I've made some significant changes already. The main point here is that a lot of the functionality is actually the same interest rate but split out in commands. I've made it so they are now all in the same one.
And:
Just an example, all comes from two commands: |
I still need to go over all other commands and I still need to put everything into context. Why is this relevant to look at, does this allow for a detailed analysis of any kind? If not, what's missing? Etcetera. |
@northern-64bit Can you look into the implementation of ICE BoFA, Moody's and Spot Rates? Jira tickets for that exist already. These will form the basis for the "Corporate Bonds" section. Slowly getting there, still lots to do. |
@JerBouma are you going to change the guides/documentation to reflect the changes. |
a5129c4
to
99fb987
Compare
@jmaslek I've updated the Fixed Income documentation and docstrings. Should now be clear. Also made sure that within the SDK you can view the options relatively easy. For example:
And So.. Ready for Review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legggoooooo
Description
Adding a fixed income menu to the terminal.
Will cover the following:
Credit Ratings for now not available (because paid). We'll be able to calculate the spreads with the ICE BoFa benchmarks.
How has this been tested?
Checklist:
Others