Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change integration tests environment variables + add option #4126

Merged
merged 7 commits into from
Feb 3, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Feb 3, 2023

Description

  • OPENBB_ENABLE_QUICK_EXIT=False ensures tests run
  • OPENBB_USE_ION=True ensures tests don't hang if --subproc > 0, otherwise we have to close plots manually to continue with the script
  • Added option to run tests sequentially without being verbose, e.g. python terminal.py -t --subproc 0
  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the tests Test-related work label Feb 3, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 3, 2023
@montezdesousa montezdesousa changed the title Change integration tests environment variables Change integration tests environment variables + add option Feb 3, 2023
@hjoaquim hjoaquim self-requested a review February 3, 2023 15:38
@montezdesousa montezdesousa marked this pull request as ready for review February 3, 2023 15:40
@montezdesousa montezdesousa merged commit 670084a into develop Feb 3, 2023
@montezdesousa montezdesousa deleted the hotfix/unblock_integ_tests branch February 3, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants