Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test debug mode flag #4133

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

montezdesousa
Copy link
Contributor

Description

Debug mode was only activate if DEBUG_MODE equals "true", escaping "True" for instance.

Integration tests were not raising exceptions with os.environ["DEBUG_MODE"] = "True". This PR sets lower case before comparing.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added bug Fix bug tests Test-related work labels Feb 5, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 5, 2023
montezdesousa added a commit that referenced this pull request Feb 6, 2023
@montezdesousa montezdesousa merged commit bd0338f into develop Feb 6, 2023
@montezdesousa montezdesousa deleted the hotfix/debug_true branch February 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants