-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrongly formatted values on stocks/fa/cash
#4211
Conversation
stocks/load aapl/fa/cash
stocks/fa/cash
Does this also need to be applied to some of the other commands (i.e balance/income) |
@jmaslek already being applied as the 3 of them use |
nice. sorry was being proactive and havent looked yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my end!
@jmaslek thanks for fixing the tests and reviewing! |
Description
lambda_long_number_format
by adding to more check tostr
types:a. starts with "0" -> if yes, most likely is some kind of ID
b. is a valid date (Y-M-D)
fmp_model.clean_metrics_df
Link # issue, if applicable.
Fix [Bug] Stocks/FA/Cash - Value for CIK number and Calendar Year is X.XXX M/K #4203
Screenshot of the feature or the bug before/after fix, if applicable.
After fix:
Relevant motivation and context.
🐛 💀
List any dependencies that are required for this change.
NA
How has this been tested?
stocks/load aapl/fa/income
stocks/load aapl/fa/cash
stocks/load aapl/fa/balance
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others