Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes on login #4234

Merged
merged 16 commits into from
Feb 15, 2023
Merged

Minor fixes on login #4234

merged 16 commits into from
Feb 15, 2023

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Feb 14, 2023

Aims to fix:

  • banner not showing if credentials expire --> Fixed ✔️
  • openbb --login not working --> Fixed ✔️

@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 14, 2023
@Chavithra
Copy link
Contributor

Chavithra commented Feb 14, 2023

Hi @hjoaquim,

About this part:

  • python terminal.py asking for credentials by default if OPENBB_ENABLE_AUTHENTICATION=True (should be only upon using --login

Let's leave the conditions like this for now.

Thanks

Welcome to OpenBB Terminal v2.3.1
╭─────────────────────────────────── Home ───────────────────────────────────╮
│                                                                            │
│ Information, guides and support for the OpenBB Terminal:                   │
│     intro              introduction on the OpenBB Terminal                 │
│     about              discover the capabilities of the OpenBB Terminal (h │
│     support            pre-populate a support ticket for our team to evalu │
│     survey             fill in our 2-minute survey so we better understand │
│     update             attempt to update the terminal automatically (GitHu │
│     wiki               search for an expression in Wikipedia (https://www. │
│     news               display news articles based on term and data source │
│                                                                            │
│ Configure your own terminal:                                               │
│ >   keys               set API keys and check their validity               │
│ >   featflags          enable and disable feature flags                    │
│ >   sources            select your preferred data sources                  │
│ >   settings           tune settings (export folder, timezone, language, p │
│                                                                            │
│ Record and execute your own .openbb routine scripts:                       │
│     record             start recording current session                     │
│     stop               stop session recording and convert to .openbb routi │
│     exe                execute .openbb routine scripts (use exe --example  │
│                                                                            │
│ Main menu:                                                                 │
│ >   stocks             access historical pricing data, options, sector and │
│ >   crypto             dive into onchain data, tokenomics, circulation sup │
│ >   etf                exchange traded funds. Historical pricing, compare  │
│ >   economy            global macroeconomic data, e.g. futures, yield, tre │
│ >   forex              foreign exchanges, quotes, forward rates for curren │
│ >   futures            commodities, bonds, index, bitcoin and forex        │
│ >   alternative        alternative datasets, such as COVID and open source │
│ >   funds              mutual funds search, overview, holdings and sector  │
│                                                                            │
│ OpenBB Toolkits:                                                           │
│ >   econometrics       statistical and quantitative methods for relationsh │
│ >   forecast           timeseries forecasting with machine learning        │
│ >   portfolio          perform portfolio optimization and look at portfoli │
│ >   dashboards         interactive dashboards using voila and jupyter note │
│ >   reports            customizable research reports through jupyter noteb │
│                                                                            │
╰─────────────────────────────── OpenBB Terminal v2.3.1 (https://openbb.co) ─╯
You are using the latest stable version

2023 Feb 14, 06:39 (🦋) / $

[h] help menu    [q] return to previous menu    [e] exit terminal    [cmd -h] s
                                                                               e
                            2023 Feb 14, 06:39 (🦋) / $
The OpenBB Terminal is the result of a strong community building an investment research platform for everyone, anywhere.

We are always eager to welcome new contributors and you can find our open jobs here:
https://www.openbb.co/company/careers#open-roles

Join us           : https://openbb.co/discord
Follow us         : https://twitter.com/openbb_finance
Ask support       : https://openbb.co/support
Request a feature : https://openbb.co/request-a-feature

Fill in our 2-minute survey so we better understand how we can improve the OpenBB Terminal at https://openbb.co/survey

In the meantime access investment research from your chatting platform using the OpenBB Bot
Try it today, for FREE: https://openbb.co/products/bot
@hjoaquim
Copy link
Contributor Author

@Chavithra with the conditions as it's now on the develop branch, I can't launch the terminal without an account. Is that the default behavior?

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 14, 2023

@Chavithra with the conditions as it's now on the develop branch, I can't launch the terminal without an account. Is that the default behavior?

This should not be the case. There should be nothing about accounts on develop yet by default

@hjoaquim
Copy link
Contributor Author

^I misunderstood the purpose of the condition and reverted to the original state

reviewpad[bot]
reviewpad bot previously requested changes Feb 15, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@hjoaquim hjoaquim marked this pull request as ready for review February 15, 2023 12:37
@hjoaquim
Copy link
Contributor Author

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

why?

Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openbb --login does not yield the prompt if there is no session save, it logs the user as guest. Is this the desired behavior?

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 15, 2023

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

why?

ignore. bad bot

@montezdesousa
Copy link
Contributor

openbb --login does not yield the prompt if there is no session save, it logs the user as guest. Is this the desired behavior?

poetry install solved it

@montezdesousa montezdesousa merged commit 46b230f into develop Feb 15, 2023
@jmaslek jmaslek deleted the hotfix/block_logout branch February 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants