Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Personal Access Token Commands #4266

Merged
merged 12 commits into from
Feb 17, 2023
Merged

Adds Personal Access Token Commands #4266

merged 12 commits into from
Feb 17, 2023

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Feb 16, 2023

Description

  • Summary of the change / bug fix.
    Adds Personal Access Token Commands to account menu:

  • generate

  • show

  • revoke

  • Link # issue, if applicable. NA

  • Screenshot of the feature or the bug before/after fix, if applicable.
    image

  • Relevant motivation and context.
    🚀 🌔

  • List any dependencies that are required for this change. NA

How has this been tested?

openbb --login
account
generate
show
revoke
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works NA
  • Check any related reports NA

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Feb 16, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Feb 16, 2023
@hjoaquim hjoaquim marked this pull request as ready for review February 17, 2023 10:42
Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just found a seemingly unrelated issue, where I provided the token, but openbb.login tried to look at my local session anyway. Is this expected?

Screenshot 2023-02-17 at 16 04 06

@hjoaquim
Copy link
Contributor Author

Looks good to me, I just found a seemingly unrelated issue, where I provided the token, but openbb.login tried to look at my local session anyway. Is this expected?

I think so buttt, we can always change it! Do you think that if the user provides token or email, we shouldn't look for the local session?

@montezdesousa
Copy link
Contributor

Looks good to me, I just found a seemingly unrelated issue, where I provided the token, but openbb.login tried to look at my local session anyway. Is this expected?

I think so buttt, we can always change it! Do you think that if the user provides token or email, we shouldn't look for the local session?

I'd say that if he provides token we should just check the token. The same for user/pass

@hjoaquim
Copy link
Contributor Author

I'd say that if he provides token we should just check the token. The same for user/pass

Will address this on a different PR.

@hjoaquim hjoaquim merged commit 7998ae7 into develop Feb 17, 2023
@hjoaquim hjoaquim deleted the feature/token-commands branch February 17, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants