Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle end_date with CCXT source when loading crypto #4296

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

northern-64bit
Copy link
Contributor

Description

Closes #4230

Adds better error messages and actually handles the end_date parameter when using crypto/load --source CCXT.

How has this been tested?

Using the following commands in the crypto menu:

  • load btc --start 2019-01-01 --end 2019-02-01 --source CCXT --exchange kraken
  • load btc --start 2023-01-01 --end 2023-02-01 --source CCXT --exchange kraken/candle
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@northern-64bit northern-64bit added bug Fix bug crypto Crypto related labels Feb 20, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 20, 2023
@jmaslek jmaslek merged commit 1c84da9 into OpenBB-finance:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crpyto/load - end_date does not work when --source CCXT
2 participants