Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocking #4577

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Fix mocking #4577

merged 3 commits into from
Mar 24, 2023

Conversation

IgorWounds
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@IgorWounds IgorWounds added the bug Fix bug label Mar 23, 2023
@IgorWounds IgorWounds requested review from piiq and jmaslek March 23, 2023 23:25
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 23, 2023
@IgorWounds IgorWounds marked this pull request as ready for review March 23, 2023 23:29
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@e300071). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4577   +/-   ##
==========================================
  Coverage           ?   56.13%           
==========================================
  Files              ?      587           
  Lines              ?    53543           
  Branches           ?        0           
==========================================
  Hits               ?    30059           
  Misses             ?    23484           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IgorWounds IgorWounds added this pull request to the merge queue Mar 24, 2023
Merged via the queue into develop with commit 50a20ae Mar 24, 2023
@IgorWounds IgorWounds deleted the hotfix/mutual-funds-mock branch April 1, 2023 20:08
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* fix mocking

* run tests?

---------

Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants