Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - Allow kwargs on POST endpoints #6240

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

IgorWounds
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Passing kwargs was broken for POST endpoints which hindered the development and user experience.
  2. What? (1-3 sentences or a bullet point list):

    • Handles the kwargs parameter and type hint on the package builder. Now kwargs can be passed and used.
  3. Impact (1-2 sentences or a bullet point list):

    • No noticeable impact. Allows for kwargs being passed when defined on the router.
  4. Testing Done:

    • Tested that the kwargs work and are being passed.

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Mar 20, 2024
@IgorWounds IgorWounds enabled auto-merge March 20, 2024 13:25
@IgorWounds IgorWounds added this pull request to the merge queue Mar 20, 2024
Merged via the queue into develop with commit bb6efdf Mar 20, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/type-kwargs branch March 20, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants