Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] yFinance ETF Info: Try Different Field When Missing fundInceptionDate #6260

Merged
merged 5 commits into from
Mar 30, 2024
Merged

[BugFix] yFinance ETF Info: Try Different Field When Missing fundInceptionDate #6260

merged 5 commits into from
Mar 30, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • In some instances, ETF info data does not contain the fundInceptionDate field and this caused a validation error because it was missing.

  2. What? (1-3 sentences or a bullet point list):

    • If that field is not present, use firstTradeDateEpochUtc instead.

  3. Impact:

    • Improves exception handling for edge case symbols.

  4. Testing Done:

    • Before/After: obb.etf.info("JJEB", provider="yfinance")

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Mar 27, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Mar 30, 2024
Merged via the queue into develop with commit 42a8c8f Mar 30, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/yfinance-etf-info branch March 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds