Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix tests for charting #6262

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[BugFix] Fix tests for charting #6262

merged 2 commits into from
Mar 28, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why?:

    • Test was a false positive due to a wrong implementation.

  2. What? (1-3 sentences or a bullet point list):

    • Properly mock the dataframe and OBBject attributes.

  3. Impact (1-2 sentences or a bullet point list):

    • NA

  4. Testing Done:

    • pytest openbb_platform/obbject_extensions/charting/tests/test_charting.py

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Mar 28, 2024
@montezdesousa montezdesousa added this pull request to the merge queue Mar 28, 2024
Merged via the queue into develop with commit 27a6fbb Mar 28, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/obbject-test branch March 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoaquim @IgorWounds @montezdesousa