Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Intrinio Balance Sheet Period #6343

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • A check that is used in the other statements to set the period shouldn't exist here because that is handled by a field validator. This made the line always validate to False because the value had already been mapped.
  2. What? (1-3 sentences or a bullet point list):

    • Removed line.
  3. Impact (1-2 sentences or a bullet point list):

    • More better now.
  4. Testing Done:

    • Balance sheet, annual and quarter.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Apr 25, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Apr 25, 2024
Merged via the queue into develop with commit 7f90d74 Apr 25, 2024
10 checks passed
@piiq piiq deleted the bugfix/intrinio-balance-period branch May 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants