Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] - Remove unused old code #6395

Merged
merged 4 commits into from
May 13, 2024
Merged

[BugFix] - Remove unused old code #6395

merged 4 commits into from
May 13, 2024

Conversation

IgorWounds
Copy link
Contributor

@IgorWounds IgorWounds commented May 12, 2024 •
edited
Loading

  1. Why? (1-3 sentences or a bullet point list):

    • This code is not needed and I would consider it an artefact.

  2. What? (1-3 sentences or a bullet point list):

    • Removes unused artefact code.
    • Fixes a bug when FileNotFound error on routine execution.

  3. Impact (1-2 sentences or a bullet point list):

    • Should make the code structure a bit leaner.

  4. Testing Done:

    • Made sure it doesn't break anything.

@IgorWounds IgorWounds requested a review from hjoaquim May 12, 2024 14:00
@IgorWounds IgorWounds added the cli OpenBB Platform CLI label May 12, 2024
@github-actions github-actions bot added the bug Fix bug label May 12, 2024
@hjoaquim hjoaquim enabled auto-merge May 13, 2024 08:20
@hjoaquim hjoaquim added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit b99655a May 13, 2024
7 checks passed
@IgorWounds IgorWounds deleted the bugfix/remove-old-code branch May 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
bug Fix bug cli OpenBB Platform CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorWounds @hjoaquim