Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Styling adjustments #6408

Merged
merged 12 commits into from
May 14, 2024
Merged

[Feature] Styling adjustments #6408

merged 12 commits into from
May 14, 2024

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 14, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Make the CLI look better
  2. What? (1-3 sentences or a bullet point list):

    • Don’t indent the Cached Results section, and put the Cached Results as the [info] in orange and put the “OBBX” in yellow to stand out
  3. Impact (1-2 sentences or a bullet point list):

    • NA
  4. Testing Done:

    • Run the CLI

Main menu on the left and other menus on the right:

image

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label May 14, 2024
@github-actions github-actions bot added enhancement Enhancement labels May 14, 2024
@montezdesousa
Copy link
Contributor

montezdesousa commented May 14, 2024

@hjoaquim just noticed that Cached Results has a different color depending on the menu where it is.

Also results command has no --help autocompletion.

Screenshot 2024-05-14 at 11 23 46

@hjoaquim
Copy link
Contributor Author

Re @montezdesousa: addressed those questions:

  1. autocompletion on the main menu commands
  2. cached results look the same in all menus now (including main, w the difference that main has the results command)

@hjoaquim hjoaquim enabled auto-merge May 14, 2024 13:34
@hjoaquim hjoaquim added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit c2f5f7a May 14, 2024
7 checks passed
@hjoaquim hjoaquim deleted the feature/didier-style branch May 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli OpenBB Platform CLI enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants