Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Default API Settings #6466

Merged
merged 3 commits into from
May 27, 2024
Merged

[BugFix] Default API Settings #6466

merged 3 commits into from
May 27, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented May 24, 2024

  1. Why?:

    • Default API settings was not updated for license change.

    • Setting the default 'url' for the API as http://localhost is not able to communicate with Docker and will create a mismatch between the CL launch for the server, and what is run by the OpenBB App script.

  2. What?:

    • Change license to AGPLv3

    • Change the default server url to an empty string.

  3. Impact (1-2 sentences or a bullet point list):

    • Docker can be run without first writing a system_settings.json file to the container.
  4. Testing Done:

    • With and without Docker.
    • This can be tested by running the uvicorn CL launch with a different host or port number than what is configured by default (http://localhost:8000). Removing the default setting fixes a network error that would otherwise occur in the Swagger docs.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels May 24, 2024
@deeleeramone deeleeramone requested a review from piiq May 24, 2024 21:05
@github-actions github-actions bot added the v4 PRs for v4 label May 24, 2024
@IgorWounds IgorWounds added this pull request to the merge queue May 27, 2024
Merged via the queue into develop with commit 27d448e May 27, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/api-settings branch May 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants