Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create openbb-cli .dockerfile and update docs #6485

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Jun 5, 2024

  1. Why?

    • Users need to build the platform image to run it
  2. What?

  3. Impact

    • NA
  4. Testing Done:

    • Run the commands in the docs

@github-actions github-actions bot added the enhancement Enhancement label Jun 5, 2024
@montezdesousa montezdesousa marked this pull request as ready for review June 5, 2024 18:24
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI might not be suitable for a Docker image because it really doesn't like window creation.

@montezdesousa
Copy link
Contributor Author

CLI might not be suitable for a Docker image because it really doesn't like window creation.

It's possible to create windows (seen it with firefox and jupyter notebooks), sounds a good issue to open.

Meanwhile we keep the package with just non-interactive tables available or we remove it?

cc: @jmaslek

@piiq
Copy link
Contributor

piiq commented Jun 6, 2024

I vote for removing the cli docker

@deeleeramone
Copy link
Contributor

I vote for removing the cli docker

Agreed, non-interactive tables does not do anything for the charts.

@montezdesousa montezdesousa added this pull request to the merge queue Jun 12, 2024
Merged via the queue into develop with commit 1a283b6 Jun 12, 2024
6 checks passed
@IgorWounds IgorWounds deleted the feature/ghcr-images branch June 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants