Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace Nasdaq SP500 Multiples With Direct Source #6609

Merged
merged 15 commits into from
Aug 8, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • The only provider for this data has stopped updating their endpoint and can be replaced with the direct source.
  2. What?:

    • Add actionable warning when the command is run with nasdaq as the provider.
  3. Impact:

    • Adds a new provider module, that is not yet published to PyPI.
    • Multiple items allowed for series_name.
  4. Testing Done:

    • Integration/Unit tests.
    • Checked the warning is being broadcast as expected.

image

@IgorWounds IgorWounds added this pull request to the merge queue Aug 8, 2024
Merged via the queue into develop with commit 3a25aa8 Aug 8, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/sp500-multiples-replacement branch August 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants