Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Flatten Revenue By Geography and Business Line #6624

Merged
merged 15 commits into from
Sep 5, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • The nested response is incompatible with the Excel add-in.
  2. What?:

    • We flatten the object and return in the style of a pivot table.
    • Remove unnecessary query parameter - "structure".
    • Move "period" from the standard model to the FMP model.
  3. Impact:

    • Breaking changes:
      • The response object is now a flat list of records.
      • No more "structure" parameter.
    • Improved response object and better cross-product compatibility.
  4. Testing Done:

    • Unit/integration tests.

Screenshot 2024-08-13 at 3 01 29 PM

Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeleeramone deeleeramone added this pull request to the merge queue Sep 5, 2024
Merged via the queue into develop with commit 4311c68 Sep 5, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/flatten-rev-segments branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants