Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] obb.derivatives.futures.historical: Fix Start/End Filters Not Being Applied. #6721

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Start/End dates were not being filtered from the openbb-yfinance provider in obb.derivatives.futures.historical
obb.derivatives.futures.historical(symbol='es',start_date='2024-09-20',end_date='2024-09-30').to_df()
  1. What?:

    • It was passing an inner function param name instead of the out function's.
  2. Impact:

    • Just this one fetcher.
  3. Testing Done:

    • Before/After.

After:

date open high low close volume
2024-09-20 5714.75 5717.25 5699.25 5699.99 1.62366e+06
2024-09-23 5762 5784.5 5745.25 5776.75 1.07794e+06
2024-09-24 5774 5794.25 5754.75 5792 1.18122e+06
2024-09-25 5792.25 5798.75 5768 5779 1.04366e+06
2024-09-26 5783.5 5830 5778.25 5804.5 1.36003e+06
2024-09-27 5804.25 5821.5 5782 5791.25 1.36003e+06
2024-09-30 5784 5804.25 5756.25 5803.5 1.0484e+06

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Sep 30, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit 2cf4f79 Oct 1, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/futures-historical-dates branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants