Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Start/End Date Filters To SecCompanyFilingsFetcher #6757

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • While working on some other code that relies on this query, it became very evident this parameter should exist.
  2. What?:

    • Adds the ability to filter start/end dates.
    • Adds the ability to filter by multiple form types.
  3. Impact:

    • Enhanced outputs with targeted specificity to improve downstream operations relying on this function.
    • All filtering is done post-request, so there is no performance improvement collecting the forms.
  4. Testing Done:

    • Updated integration tests with the new SEC parameters.
    • With/without start/end dates.
    • Multiple form types.

Warnings are collected if multiple form types are provided, but not all are valid.

[Warning_(category='UserWarning', message='Invalid form type: 10-9')]

Screenshot 2024-10-10 at 10 29 43 AM

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Oct 10, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 737e5d4 Oct 11, 2024
10 checks passed
@piiq piiq deleted the feature/sec-filings-date-filter branch October 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants