Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Handle Abusively Large Correlation Matrix. #6807

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • When a large dataset is supplied to the correlation matrix, the chart does not gracefully handle overload.
  2. What?:

    • Enables a hovertemplate that ignores the masked values.
      • Chart can now be read even when impossibly small.
    • Set the colorbar xref to be the container so that it can't overlap with the heatmap.
  3. Impact:

    • Improved ability to tolerate large inputs while providing a readable output.
  4. Testing Done:

    • Matrix with the Nasdaq 100 constituents.

Screenshot 2024-10-18 at 1 23 43 PM

- Zooming in:
Screenshot 2024-10-18 at 1 41 23 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Oct 18, 2024
@deeleeramone deeleeramone added this pull request to the merge queue Oct 19, 2024
Merged via the queue into develop with commit 06186b7 Oct 19, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/large-correlation-matrix branch October 23, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants