Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "smoothing" to "window" in EMG Settings #1158

Closed
philippitts opened this issue Jun 28, 2023 · 0 comments
Closed

Rename "smoothing" to "window" in EMG Settings #1158

philippitts opened this issue Jun 28, 2023 · 0 comments
Assignees
@retiutut

Comments

@philippitts
Copy link
Member

Problem

Both the EMG Joystick and EMG Settings windows have a parameter for "smoothing". This can be confusing since one affects the joystick itself and one affects individual EMG channels.

Expected

Rename the EMG Settings "smoothing" parameters to "window" since this value really reflects the window size over which the moving thresholds algorithm is performed.

GUI Version

5.2.0
@philippitts philippitts changed the title Rename "smooting" to "window" in EMG Settings Rename "smoothing" to "window" in EMG Settings Jun 28, 2023
retiutut added a commit that referenced this issue Jun 29, 2023
@retiutut
Rename "smoothing" to "window" in EMG Settings #1158
8de8f49
@retiutut retiutut mentioned this issue Jun 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retiutut retiutut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@retiutut @philippitts