Major Refactor of Networking Widget

[retiutut]

Problem

W_Networking.pde is a "hot mess".

Expected

• Remove unnecessary code
• Reconfirm all data outputs for all data modes or improve as needed

Operating System and Version

All OS

GUI Version

v5.0.4

Running standalone app

App and Dev

Type of OpenBCI Board

All boards

Are you using a WiFi Shield?

All boards

Console Log

It's great that the networking widget prints information to console when new stream is started. Keep doing this!

---

• For certain data types, Networking widget does not stream data unless the corresponding widget is open. GUI 5.0.4 streams out 0's or null instead. Begin to look into this. Make a new ticket if it seems reasonably possible to compute all data in the background even if some widgets aren't open. Target widget must be open in order to stream from networking widget #1094

• Remove unnecessary code

• Reconfirm all data outputs for all data modes or improve as needed

• LSL - Look at all instances of push_sample and push_chunk to see what is correct and proper, and make changes so that this networking mode is refined and can operate as the "most-used" protocol.

• Double check networking output guide.... mention that data may be sent in "chunks"for LSL and maybe other data modes. (e.g. [[sample1 s1 s1 s1],[sample2 s2 s2 s2],[sample3 etc.]] )

• Confirm and review Serial

• Confirm and review UDP

• Confirm and review OSC

• Confirm and review LSL

[retiutut]

Another user has noticed some possible quirky behavior in #989

[retiutut]

Relates heavily to #1042

[retiutut]

Workable fix exists using NeuroFly project GUI. Port fixes to networking widget there to the public GUI.

[retiutut]

For certain data types, Networking widget does not stream data unless the corresponding widget is open. GUI 5.0.4 streams out 0's or null instead. Begin to look into this. Make a new ticket if it seems reasonably possible to compute all data in the background even if some widgets aren't open. #1094