Refactor Networking Widget - June 2023 #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retiutut
force-pushed
the
june2023-networking-refactor
branch
3 times, most recently
from
43818a5
to
8a4227c
Compare
retiutut
force-pushed
the
june2023-networking-refactor
branch
from
f7f7f25
to
ad1eb08
Compare
- allows for multiple streams - Tested using networking test kit
retiutut
force-pushed
the
june2023-networking-refactor
branch
from
743d70f
to
6218ed2
Compare
…SeriesRaw data types
…ess textfields Add access modifiers to entire file
|
@mhrahmani you are welcome to review and test also! |
|
ICYMI I did a test: Mainly the Time Series crashes, and FFT has addressing conflicts. |
There was a problem hiding this comment.
Just finished testing UDP with all boards and data types. The refactored networking widget is working well on my side! Here are my notes from testing:
- When receiving Cyton filtered/unfiltered UDP time series I am seeing that I am receiving 10 samples per channel (Only seeing 5 samples per channel for CytonDaisy, 8 for Ganglion). Would be good to add a note to the time series section of the output guide.
- CytonDaisy FFT UDP stream is too large to receive using networking test script. If I expand the receiving buffer size it works fine.
- I am only receiving 2 values when receiving the pulse UDP stream instead of 3.
- Receiving UDP stream average sampling rate for bandpower, FFT, focus is slower than actual board sampling rate for all 3 boards (not sure if this is expected since these require more compute). Seeing the same thing with EMG (~125Hz for all 3 boards). NOTE: Nevermind I just saw your note that all other outputs besides timeseries sampling rate should be equivalent to current framerate 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist from #971
Remove unnecessary code
Reconfirm all data outputs for all data modes or improve as needed
LSL - Look at all instances of push_sample and push_chunk to see what is correct and proper, and make changes so that this networking mode is refined and can operate as the "most-used" protocol.
Double check networking output guide.... mention that data may be sent in "chunks"for LSL and maybe other data modes. (e.g. [[sample1 s1 s1 s1],[sample2 s2 s2 s2],[sample3 etc.]] ) Update GUI Networking Widget Guide and Data Outputs Documentation#170
Confirm and review Serial
Confirm and review UDP
Confirm and review OSC
Confirm and review LSL