Update to Processing 4 beta 3 CI pipeline #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Andrey1994 Can you upload the latest BrainFlow jar that supports all 3 OS and Java 11 to this branch? |
|
link to the latest jar to try https://github.com/brainflow-dev/brainflow/releases/download/4.8.2/brainflow-jar-with-dependencies.jar |
retiutut
changed the title
|
@Andrey1994 I have tested each board, playback mode, synthetic mode, and the base processing.serial.Serial class for Cyton dongle coms. I did not test the WiFi shield as it is discontinued at this time and probably works also. Processing 4 beta 3 uses Java 17 and JavaFX 17, whereas this PR began with Processing 4 beta 2 which uses Java 11. I hope this should be ok with forward compatibility. |
Andrey1994
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to update the entire GUI to use Processing 4 and OpenJDK 11 (aka Java 11). Processing 4 is now in the beta stage and is much more stable than it was a year ago. I have been testing this periodically since the first Processing 4 release, and it seems it is finally time to make this change for the GUI.
Fixes RadioConfig Buttons Crash GUI w/ Processing 4 #674
Update BrainFlow jar to one that uses Java 11
Fixes The type Serial is ambiguous. #1025
Test all BrainFlow boards in the GUI using updated BrainFlow jar