Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters UI team review #1046

Merged
merged 16 commits into from
Apr 28, 2022
Merged

Filters UI team review #1046

merged 16 commits into from
Apr 28, 2022

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Apr 25, 2022 •
edited
Loading

  • Revert Filter settings to default values with a simple button
  • Change “Custom” to “Per Channel” in the “Channels” dropdown
  • Adjust FilterUI header text alignment and spacing
  • Visual feedback that changes were registered
  • Remove Channel Select dropdown in the header and replace with new "Expander" between All channel control and numbered channels
  • Make sure only one FilterUI popup can be open at a time. Do this without making a static class.

@retiutut retiutut marked this pull request as ready for review April 25, 2022 20:55
Andrey1994
Andrey1994 reviewed Apr 27, 2022
View reviewed changes
OpenBCI_GUI/FilterUI.pde Outdated
// Draw visual feedback that a channel was modified
if (masterFilterSettingWasModified) {
int timeDelta = millis() - masterFilterSettingWasModifiedFadeCounter;
// Fade the color alpha value from 190 to 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment to this part? at the first sight I dont fully understand whats happenning here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrey1994 done.

@Andrey1994 Andrey1994 self-requested a review April 28, 2022 15:03
@retiutut retiutut merged commit 0d82b7a into development Apr 28, 2022
@retiutut retiutut deleted the filters-ui-team-review branch April 28, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrey1994 Andrey1994 Andrey1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retiutut @Andrey1994