Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainflow streamer file bugs #1183

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Sep 1, 2023

@retiutut retiutut marked this pull request as ready for review September 13, 2023 22:21
@retiutut
Copy link
Member Author

retiutut commented Sep 14, 2023

Steps to replicate #1105

  • Start Session with Session Data set to BDF+
  • Close Session
  • Restart Session using BDF+ output

Error shows using Windows 11:

=================================================
||             INITIALIZING SYSTEM             ||
=================================================

[ERROR]: ERROR: brainflow.BrainFlowError: Error in add_streamer:GENERAL_ERROR when initializing Brainflow board. Data will not stream.
brainflow.BrainFlowError: Error in add_streamer:GENERAL_ERROR
        at brainflow.BoardShim.add_streamer(BoardShim.java:1365)
        at brainflow.BoardShim.add_streamer(BoardShim.java:1383)
        at brainflow.BoardShim.add_streamer(BoardShim.java:1388)
        at OpenBCI_GUI$BoardBrainFlow.initializeInternal(OpenBCI_GUI.java:2714)
        at OpenBCI_GUI$BoardCyton.initializeInternal(OpenBCI_GUI.java:3300)
        at OpenBCI_GUI$Board.initialize(OpenBCI_GUI.java:2325)
        at OpenBCI_GUI.initSystem(OpenBCI_GUI.java:773)
        at OpenBCI_GUI.systemInitSession(OpenBCI_GUI.java:1110)
        at OpenBCI_GUI.draw(OpenBCI_GUI.java:654)
        at processing.core.PApplet.handleDraw(PApplet.java:2094)
        at processing.opengl.PSurfaceJOGL$DrawListener.display(PSurfaceJOGL.java:840)
        at jogamp.opengl.GLDrawableHelper.displayImpl(GLDrawableHelper.java:692)
        at jogamp.opengl.GLDrawableHelper.display(GLDrawableHelper.java:674)
        at jogamp.opengl.GLAutoDrawableBase$2.run(GLAutoDrawableBase.java:443)
        at jogamp.opengl.GLDrawableHelper.invokeGLImpl(GLDrawableHelper.java:1293)
        at jogamp.opengl.GLDrawableHelper.invokeGL(GLDrawableHelper.java:1147)
        at com.jogamp.newt.opengl.GLWindow.display(GLWindow.java:782)
        at com.jogamp.opengl.util.AWTAnimatorImpl.display(AWTAnimatorImpl.java:81)
        at com.jogamp.opengl.util.AnimatorBase.display(AnimatorBase.java:453)
        at com.jogamp.opengl.util.FPSAnimator$MainTask.run(FPSAnimator.java:178)
        at java.base/java.util.TimerThread.mainLoop(Timer.java:566)
        at java.base/java.util.TimerThread.run(Timer.java:516)
OpenBCI_GUI: Configuring Cyton Channel Count...
OpenBCI_GUI: Channel count set to 8

This PR resolves this issue.

@philippitts
Copy link
Member

Replicated the problem using the development branch and confirmed the fix here.

@retiutut retiutut merged commit 95f8554 into development Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants