-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EV certificate signing for Windows builds #1186
Add EV certificate signing for Windows builds #1186
Conversation
df339e6
to
481f3c2
Compare
Looking great so far. Did an early review. |
c03f6ea
to
fc422f5
Compare
@retiutut can you double check that the BrainFlow library setup for MacOS is still correct? I ran builds on Windows and MacOS and they seem correct, but it would be great to have you confirm it. |
The v5 GUI used to store build artifacts with timestamps in the names, but we've taken those out for v6. If you prefer to have timestamps in the name we can just drop the related commit and it should work. However, I think we can use versioning for the artifacts in AWS and it will work better. |
release/package.py
Outdated
|
||
if LOCAL_OS == MAC: | ||
shutil.move(flavors[LOCAL_OS] + ".dmg", new_name + "macosx.dmg") | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not explicit here that this is the case for Windows. Can we make it more obvious?
GUI_VERSION_STRING=`cat temp/versionstring.txt` | ||
python $GITHUB_WORKSPACE/release/build.py | ||
cp $GITHUB_WORKSPACE/OpenBCI_GUI/sketch.icns $GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app/Contents/Resources/sketch.icns | ||
dmgbuild -s release/mac/dmgbuild_settings.py -D app=$GITHUB_WORKSPACE/application.macosx/OpenBCI_GUI.app \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to sign both the Mac app (application) and the dmg (package).
Updated the PR based on your feedback and tested on Windows, MacOS, and Linux. Things are working as expected and it's ready for another review pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks Phil!
make_release.py
scriptmake_release.py
script into abuild.py
andpackage.py
script