Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English Word Suggestion 🎯 🏁 #121

Closed
bauripalash opened this issue Dec 11, 2019 · 9 comments · Fixed by #124
Closed

Add English Word Suggestion 🎯 🏁 #121

bauripalash opened this issue Dec 11, 2019 · 9 comments · Fixed by #124
Assignees
Labels
Enhancement Solved The issue is already solved

Comments

@bauripalash
Copy link

While using OBK for some days and I have felt that if it had option to add the English word i just typed , it would be really helpful.

Let me Explain :

if I type key here i would see these suggestions কী, কে, কই, কেয়, কয়েয়, ক্যায় , but what if I actually wanted to type the English word key. Then I have to go the top bar and change the input language to English. But it is definitely not a smooth experience . If we get the English word suggestion after the Bengali word suggestions (something like : কী, কে, কই, কেয়, কয়েয়, ক্যায় , key) it would be really cool and make the experience lot more smooth.

@mominul
Copy link
Member

mominul commented Dec 11, 2019

A similar feature has been implemented, I have set a key binding(Default: Ctrl + T) which will commit the English word:
auxiliary text

But I am open to suggestions 😊

@bauripalash
Copy link
Author

That doesn't seem to be a good idea , with this any application's default keybinding will not work for example, if I try to do this in this comment, instead of a English word , my browser will open a new tab :(

@mominul
Copy link
Member

mominul commented Dec 12, 2019

Actually the key binding is configurable in the settings dialog.

I am also quite in favor of your idea of including it in the preview list, but I am confused about what approach should I take.

Any opinions? @Adyel @bdeshi @ahmubashshir @shakib609 @bauripalash

@ahmubashshir
Copy link
Contributor

I prefer including it in preview list

@Adyel Adyel changed the title [ 🎯 Feature Request] Also Add English Word Suggestion 🏁 Add English Word Suggestion 🎯 🏁 Dec 12, 2019
@Adyel
Copy link
Member

Adyel commented Dec 12, 2019

@mominul I also like this idea. Including it on the preview list will be nice.

  1. We can show the English spelling at index 0, auto-suggestion will start pointing from index 1. This way user can type in phonetic and when s/he needs to switch to English, it's just one left arrow key away.

key, | কী |, কে, কই, কেয়, কয়েয়, ক্যায়
_____⬆
Suggestion starts from here

  1. Keep the current preview list, selecting up arrow will select the English word, left and right for auto-suggestion.

@mominul
Copy link
Member

mominul commented Dec 12, 2019

@Adyel The first proposal is really good! We can add an option for disabling this feature.
The second approach would make things complex, as we allow changing the orientation of the preview list. Vertical preview list uses Up and Down keys for navigating through the items.

@bdeshi
Copy link
Member

bdeshi commented Dec 13, 2019

(sorry for late comments.)

Adyel said:

  1. We can show the English spelling at index 0, auto-suggestion will start pointing from index 1. This way user can type in phonetic and when s/he needs to switch to English, it's just one left arrow key away.

key, | কী |, কে, কই, কেয়, কয়েয়, ক্যায়
_____⬆
Suggestion starts from here

That's okay, but if I may put a spin on the idea: placing the english suggestion as the very last option might be "semantically" better.

| কী |, কে, কই, কেয়, কয়েয়, ক্যায়, key
 <-- left key loops back to this ^

that way, the more important Bangla suggestions are visible first, and a left arrow at the first item cycles back to english word.

--
@mominul @Adyel

@bauripalash
Copy link
Author

bauripalash commented Dec 13, 2019

@bdeshi , That's what I suggested at first. It will be more easy use.. as OBK's first priority should be bengali words

@mominul
Copy link
Member

mominul commented Dec 16, 2019

This feature has been implemented by #124 ! 🎉
Thanks to all of you who joined the conversation!

This feature will be available in the next version!

@Adyel Adyel added the Solved The issue is already solved label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Solved The issue is already solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants