OpenBangla Keyboard should respect primary OS keyboard #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanu404
reviewed
Jun 8, 2018
| @@ -24,51 +24,10 @@ void FixedLayoutParser::setLayout(QJsonObject l) { | |||
| layout = l; | |||
| } | |||
|
|
|||
| QString FixedLayoutParser::getCharForKey(int keyNum, bool shift, bool altgr, bool shiftaltgr) { | |||
| QString FixedLayoutParser::processAlphabetKey(int keyNum, bool shift, bool altgr, bool shiftaltgr) { | |||
There was a problem hiding this comment.
Why not just rename this to getCharForKey and be with it? 🤔
There was a problem hiding this comment.
Yes, I am also not very satisfied with this implementation. I had to do this because we now only check shift or other modifiers when the key is an alphabet key. But when the key is a metacharacter or numeric we need to handle them differently, if you look them closely.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBangla Keyboard has always used US keyboard layout internally. But issue #36 pointed out that this causes issues when typing some characters using other keyboard layouts such as DE, Fr etc.
We now respect the primary OS keyboard layout. So OBK is now keyboard layout independent! 🎉
Closes #36