Order details dispute #529

rmisio · 2017-06-27T16:04:00Z

This PR adds the following functionality to the Order Details overlay:

Ability to open a dispute
Ability for a mod to decide on a dispute
The UI for a user to accept a payout
The Pay For Order section as in the Purchase flow

There are some server bugs blocking the completion of the dispute resolution, notably:

A socket is missing that would go to the other party when a payout is accepted. So, for now, if you are viewing an order that a mod has made a decision on and the other party accepts the payout, you'll need to refresh.
Please provide socket to other party when a dispute payout is accepted. openbazaar-go#556
Payout amounts are not being set properly in the Order / Case data. openbazaar-go#548
There are at least a couple of places where the server is not properly handling low priced items. For now, please test this purchasing an item of at least $10.
the closedispute api triggers a panic openbazaar-go#558

closes #529

…arty received 100%

…ress bar on a refund

…n the order detail overlay

rmisio · 2017-06-27T16:06:31Z

js/models/order/Case.js

@@ -40,6 +40,15 @@ export default class extends BaseModel {
      // convert price fields
      response.vendorContract.buyerOrder.payment.amount =
        integerToDecimal(response.vendorContract.buyerOrder.payment.amount, true);
+
+      // if (response.resolution) {


This will be needed once the server is properly providing the payout amount. I'll uncomment it then.

rmisio · 2017-06-27T16:07:01Z

js/models/order/Order.js

@@ -47,6 +47,15 @@ export default class extends BaseModel {
      // convert price fields
      response.contract.buyerOrder.payment.amount =
        integerToDecimal(response.contract.buyerOrder.payment.amount, true);
+
+      // if (response.contract.disputeResolution) {


This will be needed once the server is properly providing the payout amount. I'll uncomment it then.

rmisio · 2017-06-27T16:08:07Z

js/views/modals/listingDetail/Listing.js

@@ -312,7 +312,7 @@ export default class extends BaseModal {
      this.totalPrice = _totalPrice;
      const adjPrice = convertAndFormatCurrency(this.totalPrice,
        this.model.get('metadata').get('pricingCurrency'), app.settings.get('localCurrency'));
-      this.getCachedElement('.js-price').text(adjPrice);


Shortened this guy's name.

rmisio · 2017-06-27T16:11:22Z

js/views/modals/purchase/Payment.js

@@ -1,29 +1,44 @@
+/*


Made a few tweaks to this view to make it more friendly to be re-used in multiple areas, notably:

Made the inputs more explicit. It had been relying on two models to be passed in, but the Order Detail overlay does not have the same models (at least with the same structure), so I switched it were you just directly pass in the data it needs as options.

Updated the view so it handles partial payments. In case someone (probably accidentally) makes a partial payment from an external wallet, the totals will be updated to reflect that and if they want to pay the rest from the internal wallet (Pay From Wallet action), it will only send the remaining balance.

…s accepted

jjeffryes

Tested, no issues found. Just have some questions in the review and one spot that may need an unbind in remove.

jjeffryes · 2017-06-29T19:18:55Z

js/models/order/Contract.js

@@ -15,6 +15,10 @@ export default class extends BaseModel {
      .get('contractType');
  }

+  get orderTotal() {
+    return 99;


What does this do?

jjeffryes · 2017-06-30T17:26:55Z

js/views/modals/orderDetail/ResolveDispute.js

+      throw new Error('Please provide an OrderFulfillment model.');
+    }
+
+    const isValidParticipantObject = (participant) => {


This function gets repeated several times, is it worth centralizing it somewhere?

jjeffryes · 2017-06-30T17:28:49Z

js/views/modals/orderDetail/ResolveDispute.js

+      throw new Error(getInvalidParticpantError('buyer'));
+    }
+
+    options.buyer.getProfile().done(profile => {


For this and the various other get profile calls, is it worth doing something if the call fails?

It's not necessary because all the profiles are lazy loaded in and the view supports them not being there. For example, let's say we display the text "Billy made a purchase" with Billy being the buyer's name. Until Billy's profile is loaded, it will say "The buyer made a purchase" and when the profile arrives the name will pop in. When it's cached, it's so fast you barely notice the change.

In every case it should work similarly (sometimes, it's a GUID in place of handle, etc...). And, the lack of a profile does not prevent any functionality.

jjeffryes · 2017-06-30T17:38:48Z

js/views/modals/orderDetail/ResolveDispute.js

+      this.onResolveDisputeAlways);
+
+    this.boundOnDocClick = this.onDocumentClick.bind(this);
+    $(document).on('click', this.boundOnDocClick);


Should this be unbound in the remove?

jjeffryes · 2017-06-30T17:40:52Z

js/views/modals/orderDetail/summaryTab/DisputeStarted.js

+    return this._state;
+  }
+
+  setState(state, replace = false, renderOnChange = true) {


setState is used a lot, would it be worth it to add it to the base view?

Yes, it probably should. I didn't initially because this is a very specific way of working that only I was using and it was evolving, but even if only I use it, it won't hurt for it to be in the baseVw and devs who aren't interested in it, could leave it be.

If you don't mind though, I think I'll leave this as a separate task to circle back to, since there's now 35 occurrences of it in the app and it's probably not super high priority to work through this now. Going forward, I'll put setState() and getState() in the baseVw so we don't accumulate more technical debt and at some point I'll re-factor the other views.

That's fine.

rmisio · 2017-06-30T20:17:35Z

@jjeffryes I just addressed the code review questions / requests, but please hold off before merging. I'll look into that local pickup bug. If it's a quicky, I'll sneak it in here.

jjeffryes

I was merging the changes you made to purchasing into my own purchasing patch branch so I wouldn't overwrite them later, and it looks like the action button bug was in this PR.

jjeffryes · 2017-06-30T20:39:58Z

js/views/modals/purchase/Purchase.js

+            this.listenTo(this.payment, 'walletPaymentComplete',
+              (pmtCompleteData => this.completePurchase(pmtCompleteData)));
+            this.$('.js-pending').append(this.payment.render().el);
+            this.updatePageState('pending');


The page state needs to be updated before actionBtn is rendered, or it renders the wrong state.

I think this is what caused #533.

jjeffryes · 2017-06-30T20:40:16Z

js/views/modals/purchase/Purchase.js

            this.actionBtn.render();
            this.purchase.set(this.purchase.parse(data));
-            this.payment.render();
+            this.payment = this.createChild(Payment, {


Shouldn't there be a if (this.payment) this.payment.remove(); before this?

Since we're only going to post ob/purchase once, I don't think it's necessary. Do you see any possible scenario where that guy would be posted more than once?

It shouldn't, but in #533 it looked like it was being appended twice. Though that may just be because the pay button could be clicked twice.

jjeffryes · 2017-07-03T20:10:13Z

@rmisio there's a weird bug in fulfillment for physical orders. Somehow when the physicalDelivery data is passed from FulfillOrder.js to utils/order.js/fulfillOrder, the shipper and tracking number are both reset to blank.

It throws an error and you can't fulfill any orders.

Uncaught Error: physicalDelivery.shipper: Please provide a shipping carrier.
    at C:/Users/J/ob/openbazaar-desktop/js/utils/order.js:174:17

rmisio · 2017-07-05T16:43:54Z

@jjeffryes

there's a weird bug in fulfillment for physical orders. Somehow when the physicalDelivery data is passed from FulfillOrder.js to utils/order.js/fulfillOrder, the shipper and tracking number are both reset to blank.

ok, should be fixed now.

jjeffryes · 2017-07-06T17:05:53Z

When a dispute is decided but not accepted, should the payout section show zero prices for everything?

jjeffryes · 2017-07-06T17:09:03Z

Re: zero prices, that's probably because it's a low price transaction, and the payout was eaten by fees, wasn't it?

@morebrownies I think that could be confusing, should we show a message somewhere explaining that?

jjeffryes · 2017-07-06T17:43:30Z

For some reason the dispute with a settlement of all zeroes is stuck in the decided state for the buyer and seller, but not the moderator. That appears to be a server issue.

morebrownies · 2017-07-06T17:50:35Z

Re: zero prices, that's probably because it's a low price transaction, and the payout was eaten by fees, wasn't it?

@morebrownies I think that could be confusing, should we show a message somewhere explaining that?

Well hmmm. That's an interesting scenario. I'm wondering if we should even allow a party to open a dispute when the payout will result in 0? At that point, you're disputing for the point of disputing, but there's no financial outcome for any party involved in the dispute, including the moderator.

That may open a bigger can of worms, but the easiest thing would probably be to display a message when opening a dispute and viewing the payout details, "The bitcoin transaction fee will be $2.47 (estimated), which has been deducted from the payout totals."

jjeffryes · 2017-07-06T17:58:14Z

That may open a bigger can of worms, but the easiest thing would probably be to display a message when opening a dispute and viewing the payout details, "The bitcoin transaction fee will be $2.47 (estimated), which has been deducted from the payout totals."

I think that would be a decent approach. Though we'd also want to subtract the moderator fee (which is also estimated, since the moderator can change it).

I'll file an issue for it, it's not something we need to do immediately.

rmisio added 26 commits June 15, 2017 16:34

WIP dispute order form

c0afedd

seperated out the order details moderator fragment into its own view

eba2fd7

removing some files

8fcd8a6

WIP - functionlity to open a dispute

ca54ecc

removed file from git

b5c5f8c

dispute open form

41432a1

wiring in updating order details based on the disputeOpen notification

1fee72e

WIP - starting on the Resolve Dispute form

87b9420

additional work on the resolve dispute form

daaae5f

Completed the resolve dispute form

66e7c02

implemented the resolve dispute section

1198c4b

handling issue where payout amount not set for a party if the other p…

1d6f164

…arty received 100%

tweak to the paymount amount logic in the disputePayout template

c6f3af0

cleanup related to the dispute payout section

376dc9d

removing the pending filter from the cases tab

b2704f9

managaing the complet order form when a diuspute is opened and closed

8e21de9

adjusting the accepted event state when a dispute is opened

a3ed869

removing unused import

b0d6f6e

merging in master

4e1d3c6

tweaked the purchase payment view to accept data in a more generic way

8ba03e6

integrated the Purchase - Payment view into the Order Detail overlay

66be08d

fixing issue where the dispute icon remains in the middle of the prog…

f2ef463

…ress bar on a refund

updating the state in the transactions tables based on state change i…

28586f5

…n the order detail overlay

remove the crowd-funding listing type

0f816ab

update based on changed function name

9f56475

using payment amount for total on order details

2ca22df

rmisio commented Jun 27, 2017

View reviewed changes

rmisio added 7 commits June 27, 2017 15:32

handling dispute payout payment amounts

3f3e9ab

WIP of the dispute closed section

e6a3b98

added in a comment

bd66b86

updated handling of profile fetcher to avoid odd race condition

34dd176

showing the complete order form for the buyer when a dispute payout i…

0481894

…s accepted

finished up the dispute complete section

f799e38

Merge branch 'master' into order-details-dispute

f291f3d

jjeffryes self-requested a review June 29, 2017 15:13

fixing bug with anonymous flag in the complete order form

069b2d0

jjeffryes reviewed Jun 30, 2017

View reviewed changes

code review tweaks

7302852

jjeffryes suggested changes Jun 30, 2017

View reviewed changes

jjeffryes mentioned this pull request Jun 30, 2017

Purchase patch #544

Closed

rmisio added 2 commits June 30, 2017 14:58

handling a locl pickup item in the fulfillment related views

864464e

changing sequence of where page state is updated upon purchase

fd2b4a4

jjeffryes mentioned this pull request Jul 2, 2017

Purchase patch #548

Merged

rmisio added 2 commits July 5, 2017 09:41

fixing bug where shipping info was lost when fulfilling a physical order

3ea43bf

merging in master

c6264c5

jjeffryes approved these changes Jul 6, 2017

View reviewed changes

jjeffryes merged commit da72b26 into master Jul 6, 2017

jjeffryes deleted the order-details-dispute branch July 6, 2017 18:11

snyk-bot mentioned this pull request Aug 30, 2022

[Snyk] Fix for 2 vulnerabilities phungmobile2/openbazaar-desktop#107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Order details dispute #529

Order details dispute #529

rmisio commented Jun 27, 2017 •

edited

Loading

rmisio Jun 27, 2017

rmisio Jun 27, 2017

rmisio Jun 27, 2017

rmisio Jun 27, 2017

jjeffryes left a comment

jjeffryes Jun 29, 2017

jjeffryes Jun 30, 2017

jjeffryes Jun 30, 2017

rmisio Jun 30, 2017 •

edited

Loading

jjeffryes Jun 30, 2017

rmisio Jun 30, 2017

jjeffryes Jun 30, 2017

rmisio Jun 30, 2017 •

edited

Loading

jjeffryes Jun 30, 2017

rmisio commented Jun 30, 2017

jjeffryes left a comment

jjeffryes Jun 30, 2017

jjeffryes Jun 30, 2017

rmisio Jun 30, 2017 •

edited

Loading

jjeffryes Jun 30, 2017

jjeffryes commented Jul 3, 2017 •

edited

Loading

rmisio commented Jul 5, 2017

jjeffryes commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

morebrownies commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

Order details dispute #529

Order details dispute #529

Conversation

rmisio commented Jun 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjeffryes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmisio Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmisio Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmisio commented Jun 30, 2017

jjeffryes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmisio Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjeffryes commented Jul 3, 2017 • edited Loading

rmisio commented Jul 5, 2017

jjeffryes commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

morebrownies commented Jul 6, 2017

jjeffryes commented Jul 6, 2017

rmisio commented Jun 27, 2017 •

edited

Loading

rmisio Jun 30, 2017 •

edited

Loading

rmisio Jun 30, 2017 •

edited

Loading

rmisio Jun 30, 2017 •

edited

Loading

jjeffryes commented Jul 3, 2017 •

edited

Loading