Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Check for non-periodic Cartesian space in process setup #124

Closed
lohedges opened this issue Jul 3, 2023 · 0 comments · Fixed by #125
Closed

[BUG] Check for non-periodic Cartesian space in process setup #124

lohedges opened this issue Jul 3, 2023 · 0 comments · Fixed by #125
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

lohedges commented Jul 3, 2023

I'm not sure this wasn't caught by the local CI for the release, but we need to add a few more checks for a non-periodic space when setting up a process. (Sire now adds a default Cartesian space if no property is present.) This was fixed for NAMD here, but needs to be applied for all engines.
@lohedges lohedges added the bug Something isn't working label Jul 3, 2023
lohedges added a commit that referenced this issue Jul 3, 2023
@lohedges
Check for non-periodic cartesian space. [closes #124]
a0c7df7
@lohedges lohedges mentioned this issue Jul 3, 2023
Merged
lohedges added a commit that referenced this issue Jul 3, 2023
@lohedges
Merge pull request #125 from OpenBioSim/fix_124
5eb871f 
Fix issue #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #124 OpenBioSim/biosimspace
1 participant
@lohedges