Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Merge code no longer setting a unique connectivty property when connectivity changes #344

Closed
lohedges opened this issue Sep 27, 2024 · 0 comments · Fixed by #345
Closed

[BUG] Merge code no longer setting a unique connectivty property when connectivity changes #344

lohedges opened this issue Sep 27, 2024 · 0 comments · Fixed by #345
Assignees
@lohedges
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

It looks like this happened during the merging of the ROI code, where presumably the sandpit code was taken verbatim rather than being adapted to add the new functionality. We require a unique connectivity object in the end states when the connectivity changes, as can be done when forcing a merge.
@lohedges lohedges added the bug Something isn't working label Sep 27, 2024
@lohedges lohedges self-assigned this Sep 27, 2024
lohedges added a commit that referenced this issue Sep 27, 2024
@lohedges
Allow end-state connectivity property to differ. [closes #344]
eccf310
@lohedges lohedges mentioned this issue Sep 27, 2024
Merged
lohedges added a commit that referenced this issue Oct 2, 2024
@lohedges
Merge pull request #345 from OpenBioSim/fix_344
bdd69c6 
Fix issue #344. [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lohedges lohedges

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #344 OpenBioSim/biosimspace
1 participant
@lohedges