Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #132 #133

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix issue #132 #133

merged 2 commits into from
Jul 11, 2023

Conversation

lohedges
Copy link
Contributor

This PR closes #132. When adding guards to protect against alchemlyb being missing on various platforms, I had accidentally duplicated the logic from Process.Amber into Process.Gromacs, meaning that the wrong extract function was imported.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@chryswoods

@lohedges lohedges added bug Something isn't working exscientia Related to work with Exscientia labels Jul 10, 2023
@lohedges lohedges requested a review from chryswoods July 10, 2023 10:29
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges had a problem deploying to biosimspace-build July 10, 2023 10:29 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 11:42 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 11:42 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 11:42 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 11:42 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 10, 2023 11:42 — with GitHub Actions Inactive
chryswoods
chryswoods approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@chryswoods chryswoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lohedges lohedges merged commit 6eb3ce2 into devel Jul 11, 2023
@lohedges lohedges deleted the fix_132 branch July 11, 2023 13:52
lohedges added a commit that referenced this pull request Jul 11, 2023
@lohedges
Backport fixes from PRs #133 and #135. [ci skip]
fcf7882
@lohedges lohedges mentioned this pull request Jul 11, 2023
Merged
lohedges added a commit that referenced this pull request Jul 24, 2023
@lohedges
Merge pull request #136 from OpenBioSim/backport_133_135
60e0884 
Backport fixes from PRs #133 and #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chryswoods chryswoods chryswoods approved these changes

Assignees
No one assigned
Labels
bug Something isn't working exscientia Related to work with Exscientia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect alchemlyb extract function imported
2 participants
@lohedges @chryswoods