Update _openmm.py #144
Closed
Update _openmm.py #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that OpenMM calculates the remainingTime correctly by giving it total_steps Signed-off-by: Dom <50554130+dlukauskis@users.noreply.github.com>
|
Thanks for this. I'll need to update the same code in the Exscientia Sandpit too. I'll make a clone of your branch, then resubmit a PR, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that OpenMM calculates the remainingTime correctly by giving it total_steps
Suggested reviewers:
@lohedges
Any additional context of information?
I've tested this, it does work.