Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pv pin #1621

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Pv pin #1621

merged 2 commits into from
Oct 12, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 7, 2024

closes #1484

@jmthomas
Copy link
Member Author

jmthomas commented Oct 7, 2024

Screenshot 2024-10-07 at 10 46 46 AM

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 28.84615% with 37 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (1bb2fc7) to head (2b477e3).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...cketviewer/src/tools/PacketViewer/PacketViewer.vue 28.84% 34 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   76.81%   76.73%   -0.08%     
==========================================
  Files         614      614              
  Lines       46403    46455      +52     
  Branches      827      837      +10     
==========================================
+ Hits        35645    35649       +4     
- Misses      10666    10712      +46     
- Partials       92       94       +2     
Flag Coverage Δ
frontend 55.99% <28.84%> (-0.44%) ⬇️
python 84.59% <ø> (ø)
ruby-api 47.62% <ø> (ø)
ruby-backend 82.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit 2ed00e0 into main Oct 12, 2024
27 checks passed
@ryanmelt ryanmelt deleted the pv_pin branch October 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin items in Packet Viewer
2 participants