Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize SR output on CHECK success/failure #1654

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Colorize SR output on CHECK success/failure #1654

merged 1 commit into from
Oct 24, 2024

Conversation

jmthomas
Copy link
Member

closes #1547

if json["log"]
out_line = json["log"]
elsif json["message"]
out_line = json["message"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when we added 'message' as well as 'log' but this was causing the CHECK error messages to be unformatted json

@jmthomas
Copy link
Member Author

Screenshot 2024-10-21 at 2 42 51 PM Screenshot 2024-10-21 at 2 45 25 PM

Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (6c85e08) to head (4ac6392).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...mos-script-runner-api/app/models/running_script.rb 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
+ Coverage   76.40%   76.41%   +0.01%     
==========================================
  Files         618      618              
  Lines       46858    46867       +9     
  Branches      845      847       +2     
==========================================
+ Hits        35803    35815      +12     
+ Misses      10959    10956       -3     
  Partials       96       96              
Flag Coverage Δ
frontend 56.17% <100.00%> (+0.04%) ⬆️
python 83.90% <ø> (+0.04%) ⬆️
ruby-api 47.55% <0.00%> (-0.04%) ⬇️
ruby-backend 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit a7b71b5 into main Oct 24, 2024
27 checks passed
@ryanmelt ryanmelt deleted the sr_output branch October 24, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorize ScriptRunner output text
2 participants