Cleanup controllers and change delete 204 to 200 #1666

jmthomas · 2024-10-25T03:53:25Z

Setting status to 204 means "No content" yet we were returning content in almost all the delete cases. This was causing a bug that we just worked around in calendar.rb but was just wrong based on our use. I also changed all the controllers to match the more common Rails style of symbol keys:

render json: { key: value, more: stuff}

rather than our existing mix of hash rocket with some symbol and some string keys:

render :json => { 'key' => value, :more => stuff}

codecov · 2024-10-25T03:54:50Z

Codecov Report

Attention: Patch coverage is 32.93173% with 167 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (6b5acfc) to head (362a7f7).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...cmd-tlm-api/app/controllers/reaction_controller.rb	20.68%	23 Missing ⚠️
...-cmd-tlm-api/app/controllers/trigger_controller.rb	20.83%	19 Missing ⚠️
...cmd-tlm-api/app/controllers/activity_controller.rb	57.89%	16 Missing ⚠️
...-cmd-tlm-api/app/controllers/storage_controller.rb	0.00%	15 Missing ⚠️
...s-cmd-tlm-api/app/controllers/tables_controller.rb	0.00%	13 Missing ⚠️
...cmd-tlm-api/app/controllers/timeline_controller.rb	37.50%	10 Missing ⚠️
...lm-api/app/controllers/trigger_group_controller.rb	35.71%	9 Missing ⚠️
...cmd-tlm-api/app/controllers/packages_controller.rb	0.00%	8 Missing ⚠️
...-cmd-tlm-api/app/controllers/plugins_controller.rb	0.00%	7 Missing ⚠️
...t-runner-api/app/controllers/scripts_controller.rb	25.00%	6 Missing ⚠️
... and 21 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
+ Coverage   76.44%   76.53%   +0.09%     
==========================================
  Files         618      618              
  Lines       46891    46895       +4     
  Branches      849      849              
==========================================
+ Hits        35844    35891      +47     
+ Misses      10952    10909      -43     
  Partials       95       95

Flag	Coverage Δ
frontend	`56.14% <ø> (-0.11%)`	⬇️
python	`83.93% <ø> (-0.02%)`	⬇️
ruby-api	`48.82% <33.06%> (+1.22%)`	⬆️
ruby-backend	`82.54% <0.00%> (+<0.01%)`	⬆️