Add comma between road and house for Russia #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very happy to believe you. Please submit more ru tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me, russian addresses formatted with these templates are a bit weird, because there's no comma. We are used to "prospekt Lenina, 16", which is a short form of "prospekt Lenina, dom 16". This pull request adds commas between the road name and the house number for Russia.
References: examples on Wikipedia, russian language examples in Frank's guide, and just click anywhere in Yandex maps, the most used map portal in Russia.
Note: I'm changing the
generic10template, because it's only used for Russia. I have no idea how these templates were extracted.