Skip to content

Commit

Permalink
node: all golint warnings fixed (ethereum#16773)
Browse files Browse the repository at this point in the history
* node: all golint warnings fixed

* node: rm per peter

* node: rm per peter
  • Loading branch information
kielbarry authored and kimmyeonghun committed Jul 5, 2018
1 parent f515dbe commit 334e8f9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion node/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func (api *PrivateAdminAPI) StartWS(host *string, port *int, allowedOrigins *str
return true, nil
}

// StopRPC terminates an already running websocket RPC API endpoint.
// StopWS terminates an already running websocket RPC API endpoint.
func (api *PrivateAdminAPI) StopWS() (bool, error) {
api.node.lock.Lock()
defer api.node.lock.Unlock()
Expand Down
4 changes: 2 additions & 2 deletions node/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,8 @@ func TestAPIGather(t *testing.T) {
}
// Register a batch of services with some configured APIs
calls := make(chan string, 1)
makeAPI := func(result string) *OneMethodApi {
return &OneMethodApi{fun: func() { calls <- result }}
makeAPI := func(result string) *OneMethodAPI {
return &OneMethodAPI{fun: func() { calls <- result }}
}
services := map[string]struct {
APIs []rpc.API
Expand Down
6 changes: 3 additions & 3 deletions node/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,12 @@ func InstrumentedServiceMakerC(base ServiceConstructor) ServiceConstructor {
return InstrumentingWrapperMaker(base, reflect.TypeOf(InstrumentedServiceC{}))
}

// OneMethodApi is a single-method API handler to be returned by test services.
type OneMethodApi struct {
// OneMethodAPI is a single-method API handler to be returned by test services.
type OneMethodAPI struct {
fun func()
}

func (api *OneMethodApi) TheOneMethod() {
func (api *OneMethodAPI) TheOneMethod() {
if api.fun != nil {
api.fun()
}
Expand Down

0 comments on commit 334e8f9

Please sign in to comment.