crc table #186
Merged
crc table #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderkalyan
force-pushed
the
crc
branch
2 times, most recently
from
b5ff9ed
to
38d496c
Compare
pavel-kirienko
requested changes
Dec 2, 2021
coderkalyan
force-pushed
the
crc
branch
2 times, most recently
from
e2dcfcd
to
b68591a
Compare
|
I see that the workflow has failed because the secrets are not exposed to builds originating from forks. Should we reconfigure the workflow to skip SonarScanner unless the secrets are available? If you think this is sensible then perhaps we should fix it in this pull request. |
|
Sure, thats acceptable. Not ideal but I don't see a clean way of doing it otherwise. I'll update this PR later. |
Merged
Adds a build option `CANARD_CRC_TABLE` which replaces the runtime-computed CRC with a static table. This option adds ~512 bytes ROM but reduces computation time significantly.
pavel-kirienko
approved these changes
Dec 4, 2021
pavel-kirienko
added a commit
that referenced
this pull request
Dec 4, 2021
* Drop canard_dsdl, use Nunavut instead * Upgrade CI to LLVM 13 * Actualize license headers * Support redundant transmission queues and use more consistent public field naming * Ditch the deprecated canardRxAccept(), rename canardRxAccept2() * Refactor the API to eliminate the need to cast away const qualifiers; fixes #175 * Tighten up memory checking in the test suite -- add canaries * Fix race condition in the roundtrip test * Do not use Catch2 macros from non-main thread because it is not thread-safe * Support CANARD_CONFIG_HEADER * CI: add style_check job * Use AVL tree in the transmission queue * Remove all linked lists * Reduce indirection, pointer casts, and memory footprint by exposing the AVL tree in the public API * Disable C++-specific warnings as they make no sense for a C library * Add table-based CRC option (#186) * CI: disable SonarCloud on forks * Add docker utilities (#187) * Add acceptance filter configuration helpers (#171) Co-authored-by: Kalyan Sriram <coder.kalyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185