misra: remove flexible array #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per MISRA, flexible array members should be replaced with maximum-size allocation and the following pointer arithmetic to avoid undefined behavior. |
pavel-kirienko
requested changes
Mar 14, 2022
coderkalyan
force-pushed
the
misra
branch
2 times, most recently
from
b8b7e1b
to
9b517c2
Compare
pavel-kirienko
requested changes
Mar 21, 2022
libcanard/canard.c
Outdated
| @@ -66,6 +66,8 @@ | |||
|
|
|||
| #define INITIAL_TOGGLE_STATE true | |||
|
|
|||
| #define CANARD_MTU_MAX CANARD_MTU_CAN_FD | |||
There was a problem hiding this comment.
I think this actually should be in the header file (as I wrote earlier) because this is also useful for the API.
pavel-kirienko
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183